I created a div table of sorts, where there is a button, and that button creates a box, and what is supposed to happen is that you can click any of the {x} boxes and it colors it black However, instead of coloring that box black(or white), it colors the newest one black(or white). How do I change this?
HTML:
JavaScript
x
24
24
1
<!DOCTYPE html>2
<html>3
4
<head>5
<meta charset="utf-8">6
<meta name="viewport" content="width=device-width">7
<title>Rule 110</title>8
<link href="style.css" rel="stylesheet" type="text/css" />9
</head>10
11
<body>12
<script src="script.js"></script>13
<center><h1>Rule 110</h1></center>14
<div class="grid-container">15
16
<main id="content"></main>17
18
19
</div>20
<button onclick=add() class="button">+</button>21
</body>22
23
</html>24
Javascript:
JavaScript
1
53
53
1
const first = document.getElementById("first")2
const second = document.getElementById("second")3
const third = document.getElementById("third")4
const fourth = document.getElementById("fourth")5
const fifth = document.getElementById("fifth")6
const sixth = document.getElementById("sixth")7
const seventh = document.getElementById("seventh")8
const eigth = document.getElementById("eigth")9
const ninth = document.getElementById("ninth")10
var extra = 1;11
var thingrowx=0;12
var thingrowy = 1;13
function changeColor(test) {14
if (document.getElementById(test).className === "grid-item-white"){15
document.getElementById(test).className="grid-item-black";}16
else {17
document.getElementById(test).className="grid-item-white";18
}19
}20
21
function createTable() {22
rn = window.prompt("Input number of rows", 1);23
cn = window.prompt("Input number of columns",1);24
25
for(var r=0;r<parseInt(rn,10);r++)26
{27
var x=document.getElementById('myTable').insertRow(r);28
for(var c=0;c<parseInt(cn,10);c++) 29
{30
var y= x.insertCell(c);31
y.innerHTML="Row-"+r+" Column-"+c; 32
}33
}34
}35
function repeat(func, times) {36
func;37
times && --times && repeat(func, times);38
}39
function test() {40
document.querySelector('#content').insertAdjacentHTML(41
'afterbegin',42
`<div class="grid-item-white" id="combined" onclick=changeColor('combined')>43
</div>`44
)45
}46
function add() {47
extra += 1;48
thingrowx += 1;49
var combined = "(" + thingrowx + "," + thingrowy + ")"50
alert(combined)51
repeat(test(), thingrowy) 52
}53
CSS:
JavaScript
1
62
62
1
.button {2
border: none;3
background-color: black;4
padding: 16px 32px;5
text-align: center;6
text-decoration: none;7
display: inline-block;8
font-size: 16px;9
margin: 4px 2px;10
transition-duration: 0.4s;11
cursor: pointer;12
color: white;13
}14
15
.button1 {16
background-color: white; 17
color: black; 18
border: 2px solid #4CAF50;19
}20
21
.button1:hover {22
background-color: #4CAF50;23
color: white;24
}25
26
.button2 {27
background-color: white; 28
color: black; 29
border: 2px solid #008CBA;30
}31
32
.button2:hover {33
background-color: #008CBA;34
color: white;35
}36
37
38
.grid-container {39
display: grid;40
grid-template-columns: 50px 50px 50px 50px 0px 50px 50px 50px 0px 50px 50px 50px 50px 50px 50px 50px;41
padding: 10px;42
}43
44
.grid-item-white {45
background-color: white;46
border: 1px solid rgba(0, 0, 0, 0.8);47
padding: 20px;48
font-size: 30px;49
text-align: center;50
}51
52
.grid-item-black {53
background-color: black;54
border: 1px solid rgba(0, 0, 0, 0.8);55
padding: 20px;56
font-size: 30px;57
text-align: center;58
color: white59
}60
61
body {background-color: #cdf1eb ;}62
Advertisement
Answer
I think the problem is in the test function.
JavaScript
1
8
1
function test() {2
document.querySelector('#content').insertAdjacentHTML(3
'afterbegin',4
`<div class="grid-item-white" id="combined" onclick=changeColor('combined')>5
</div>`6
)7
}8
You’re setting the id to "combined" for every new added element. But an id must be unique for each element in the whole html document. May be you intended to do the following.
JavaScript
1
17
17
1
function test(combined) {2
// use the combined index that is passed from the add function3
document.querySelector('#content').insertAdjacentHTML(4
'afterbegin',5
// -------------------------------vvvvvvvvvvv-- use template literal6
`<div class="grid-item-white" id="${combined}" onclick=changeColor('${combined}')>7
</div>`8
)9
}10
function add() {11
extra += 1;12
thingrowx += 1;13
var combined = "(" + thingrowx + "," + thingrowy + ")"14
alert(combined)15
repeat(test(combined), thingrowy) // pass the combined index to the test method16
}17
Your code is very cluttered with poor naming and lots of unused variables and functions, so I’ve tried to refactor a little!
JavaScript
1
29
29
1
const contentElement = document.getElementById("content");2
3
contentElement.addEventListener("click", (event) => {4
// here event.target represents the element that has been clicked on5
changeColor(event.target);6
});7
8
let rowX = 0;9
let rowY = 1;10
11
function changeColor(element) {12
if (element.className === "grid-item-white")13
element.className = "grid-item-black";14
else element.className = "grid-item-white";15
}16
17
function add() {18
rowX += 1;19
const combined = "(" + rowX + "," + rowY + ")";20
21
// alert(combined);22
23
document24
.querySelector("#content")25
.insertAdjacentHTML(26
"afterbegin",27
`<div class="grid-item-white" data-id="${combined}"></div>`28
);29
}JavaScript
1
62
62
1
.button {2
border: none;3
background-color: black;4
padding: 16px 32px;5
text-align: center;6
text-decoration: none;7
display: inline-block;8
font-size: 16px;9
margin: 4px 2px;10
transition-duration: 0.4s;11
cursor: pointer;12
color: white;13
}14
15
.button1 {16
background-color: white;17
color: black;18
border: 2px solid #4caf50;19
}20
21
.button1:hover {22
background-color: #4caf50;23
color: white;24
}25
26
.button2 {27
background-color: white;28
color: black;29
border: 2px solid #008cba;30
}31
32
.button2:hover {33
background-color: #008cba;34
color: white;35
}36
37
.grid-container {38
display: grid;39
grid-template-columns: 50px 50px 50px 50px 0px 50px 50px 50px 0px 50px 50px 50px 50px 50px 50px 50px;40
padding: 10px;41
}42
43
.grid-item-white {44
background-color: white;45
border: 1px solid rgba(0, 0, 0, 0.8);46
padding: 20px;47
font-size: 30px;48
text-align: center;49
}50
51
.grid-item-black {52
background-color: black;53
border: 1px solid rgba(0, 0, 0, 0.8);54
padding: 20px;55
font-size: 30px;56
text-align: center;57
color: white;58
}59
60
body {61
background-color: #cdf1eb;62
}JavaScript
1
25
25
1
<!DOCTYPE html>2
<html>3
4
<head>5
<meta charset="utf-8" />6
<meta name="viewport" content="width=device-width" />7
<title>Rule 110</title>8
<link href="style.css" rel="stylesheet" type="text/css" />9
</head>10
11
<body>12
<center>13
<h1>Rule 110</h1>14
</center>15
16
<button onclick="add()" class="button">+</button>17
18
<div class="grid-container">19
<main id="content"></main>20
</div>21
22
<script src="script.js"></script>23
</body>24
25
</html>Here I’ve used event delegation to listen on click event on any grid items. So if we listen for click events on the #content element and use the event.target then we get the grid item that has been clicked on. Then we can pass that element to the changeColor method.
If you don’t understand anything feel free to ask me in the comment. Hope this helps.